Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Infinite reconciliation for existing buckets #1912

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mishak87
Copy link
Contributor

controller.createBuckets passes return (created, error) of tenant.createBuckets which can be also false, nil when buckets already exist

in logs this message is dumped every 20 seconds

helper.go:776] Your previous request to create the named bucket succeeded and you already own it.

@allanrogerr allanrogerr self-requested a review February 21, 2024 00:07
@allanrogerr allanrogerr merged commit 8964da7 into minio:master Feb 21, 2024
@allanrogerr allanrogerr self-assigned this Feb 21, 2024
@mishak87 mishak87 deleted the patch-1 branch February 29, 2024 01:11
@mishak87
Copy link
Contributor Author

mishak87 commented Feb 29, 2024

@allanrogerr Looking at my patch I don't think it will fix anything.
Check if buckets were provisioned is needed similar to user provisioning

if len(tenant.Spec.Buckets) > 0 {

if !tenant.Status.ProvisionedUsers && len(tenant.Spec.Users) > 0 {

and mark them as provisioned regardless if create is true

if created {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants