fix: create bucket make a conflict status for tenant. #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtripat
reviewed
Oct 30, 2023
|
I review the code and it looks good to me, let me do a quick test on this just to make sure it is not breaking the feature. On it... |
|
Create bucket on the fly: Bucket got created: 
Log: This change isn't breaking breaking the intention of creating the bucket on the fly. |
|
And I can keep on adding more, no issue observed: 
|
|
Thank you @jiuker |
shtripat
approved these changes
Oct 30, 2023
Comment on lines
+766
to
+777
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*20) | ||
| defer cancel() | ||
| allBuckets, err := minioClient.ListBuckets(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| allBucketsMap := make(map[string]bool) | ||
| for _, bucket := range allBuckets { | ||
| allBucketsMap[bucket.Name] = true | ||
| } | ||
| for _, bucket := range buckets { | ||
| if !allBucketsMap[bucket.Name] { |
There was a problem hiding this comment.
why can't we use HeadBucket here?
There was a problem hiding this comment.
I can't found that. Is there something I missed? @harshavardhana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1829