Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: containers should be omitempty like the Optional #1817

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: containers should be omitempty like the Optional #1817

merged 1 commit into from
Oct 16, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Oct 16, 2023

When someone use sidecar's resource to initcontainers's resource.
There is a error output:

Tenant.minio.min.io \"mytenant\" is invalid: spec.sideCars.containers: Required value

This pr will allow the containers can be Optional

shtripat
shtripat approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit d4c1641 into minio:master Oct 16, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiuker @harshavardhana @shtripat