Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hop Websockets #1609

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix Hop Websockets #1609

merged 2 commits into from
May 23, 2023

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented May 18, 2023

Fixes websockets in hope iframes. This was caused by a corruption of the http.ResponseWriter by the AuditLogger middleware.

To Test this PR

1.- Deploy a tenant via the Operator UI
2.- Wait for the tenant to come online
3.- in the tenant details screen, use the Hop button to get into the tenant
4.- Create a bucket, upload some files
5.- The bucket should list the files

dvaldivia added 2 commits May 18, 2023 10:02
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
@pjuarezd
Copy link
Member

Yes, I see fixed the Refused to display 'http://localhost:9090/' in a frame because it set 'X-Frame-Options' to 'deny'. that error is gone and now I get into the tenant console using HOP.

But I still don't see buckets listed, getting this error in browser console:
consoleApi.ts:1555 GET http://localhost:9090/api/v1/buckets 404 (Not Found)

Screenshot 2023-05-19 at 12 32 57 AM

I do have a bucket created in that tenant, when doing direct port-forward to the tenant console I am able to list it

Screenshot 2023-05-19 at 12 34 27 AM

I am using port-forward kubectl minio proxy

@dvaldivia
Copy link
Collaborator Author

@pjuarezd to see the buckets listed to need to build a MinIO image with my other PR in console that fixes subpath

@pjuarezd
Copy link
Member

@pjuarezd to see the buckets listed to need to build a MinIO image with my other PR in console that fixes subpath

Right, build minio/console#2818 and now I see the buckets listed.

Now the websocket still fails, could it be because I am using port-forward?, shuld NodePort or some sort of ingress be used in the Operator console for it to work?

Screenshot 2023-05-19 at 12 31 26 PM

@dvaldivia
Copy link
Collaborator Author

Let me see @pjuarezd i only tested using local and ingress not port forward

@pjuarezd
Copy link
Member

I can confirm that the HOP works on NodePort

Operator console HOP on NodePort

@pjuarezd pjuarezd merged commit e3e8878 into minio:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants