Document tenant field runtimeClassName #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement Container Security Context by Helm and Kustomize, with implementations in examples * Test should not fail if attempt is made to apply newer k8 yamls that do not correspond to older golang code. Test should revert to installing current branch of operator. * Test missing definitions * Test missing definitions * Test missing definitions * Implement Container Security Context by Helm and Kustomize, with impl… (#6) * Implement Container Security Context by Helm and Kustomize, with implementations in examples * Test should not fail if attempt is made to apply newer k8 yamls that do not correspond to older golang code. Test should revert to installing current branch of operator. * Add containersecuritycontext helm (#7) * Implement Container Security Context by Helm and Kustomize, with implementations in examples * Test should not fail if attempt is made to apply newer k8 yamls that do not correspond to older golang code. Test should revert to installing current branch of operator. * Helm test floor (#5) * Add new job to test Kubernetes 1.20 Adding new job to test for the last supported version of kubernetes * Fix shell script format * Bump K8s floor to 1.21.14 * Test floor Co-authored-by: dilverse <[email protected]> * Default to use pod security context * Rename variable for improved readability * Revert github workflow changes for testing * Apply gofumpt * Implement Container Security Context functionality in console and operator Validate Container Security Context using Helm tenant * Keep only one version of field securityContext Co-authored-by: dilverse <[email protected]>
…tem (minio#1350) The operator can be in a weird state when removing the log from the tenant yaml. If removing the audit webhook succeed but the removal of the log service fails, the operator will enter in an loop of errors because it is not ignoring 'config not found' error when deleting the webhook config again in the next try. The commit ignores XMinioConfigError and XMinioConfigNotFoundError though XMinioConfigError is not returned when a config is not found since MinIO server Dec 2022. Co-authored-by: Anis Elleuch <[email protected]>
Add a note for tenants on spec.pools.runtimeClassName as requested on minio#1337
allanrogerr
requested review from
pjuarezd,
cniackz,
reivaj05,
kannappanr,
bexsoft,
jinapurapu and
dilverse
dvaldivia
previously approved these changes
Jan 6, 2023
dvaldivia
approved these changes
Jan 6, 2023
pjuarezd
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note for tenants on spec.pools.runtimeClassName as requested on #1337
Also, clean up syntax/grammar aspects on the current documentation, and order the list