Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console TLS #1348

Merged
merged 14 commits into from
Dec 16, 2022
Merged

Console TLS #1348

merged 14 commits into from
Dec 16, 2022

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Nov 17, 2022 •
edited
Loading

In this PR:

  • Methods to create a TLS certfificate have been refactored to allow create more than one TLS Certificate
  • Operator, based on flags, autoissues a TLS Certificate for Console and restart the pods to enable the TLS port
  • Add parameter to kubectl-minio init plugin command to enable operator console tls like kubectl minio init --console-tls

New Env variables
MINIO_CONSOLE_TLS_ENABLE

Env variable to turn on / off Console TLS, default "off"

MINIO_CONSOLE_DEPLOYMENT_NAME

Name of the Console Deployment, if customized, default to "console"

@pjuarezd pjuarezd self-assigned this Nov 17, 2022
harshavardhana
harshavardhana previously requested changes Nov 17, 2022
View reviewed changes
pkg/controller/cluster/tls.go Outdated Show resolved Hide resolved
@pjuarezd pjuarezd changed the title TLS methods refactor Console TLS Dec 6, 2022
dvaldivia
dvaldivia reviewed Dec 15, 2022
View reviewed changes
kubectl-minio/cmd/init.go Outdated Show resolved Hide resolved
pkg/controller/cluster/console.go Show resolved Hide resolved
resources/base/console-ui.yaml Outdated Show resolved Hide resolved
dvaldivia
dvaldivia previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM.

@pjuarezd pjuarezd merged commit 4f12e47 into minio:master Dec 16, 2022
@pjuarezd pjuarezd deleted the tls-refactor branch December 16, 2022 20:05
@djwfyi djwfyi mentioned this pull request Jan 3, 2023
Closed
2 tasks
@pjuarezd pjuarezd mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@bexsoft bexsoft Awaiting requested review from bexsoft

@dilverse dilverse Awaiting requested review from dilverse

@reivaj05 reivaj05 Awaiting requested review from reivaj05

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

Assignees

@pjuarezd pjuarezd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjuarezd @harshavardhana @dvaldivia