Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make an additional flag for installing CRDs #1915

Open
gecube opened this issue Dec 18, 2023 · 3 comments
Open

Make an additional flag for installing CRDs #1915

gecube opened this issue Dec 18, 2023 · 3 comments
Assignees
@pjuarezd @ramondeklein @cniackz @dvaldivia
Labels
community triage

Comments

@gecube
Copy link

gecube commented Dec 18, 2023

Hello!

Other projects provides a flag like installCRDs for better management what to install - the operator or the bundle operator + CRDs.
The good example is cert-manager project: https://github.com/cert-manager/cert-manager/blob/529d8a74a679a11757ed7a30ea60d342acbdb484/deploy/charts/cert-manager/values.yaml#L53

Another possible option is to move CRDs to the separate helm chart like it was did in linkerd: https://artifacthub.io/packages/helm/linkerd2/linkerd-crds

It allows more flexible approach and workarounds some Helm bugs regarding CRDs installation. So I am kindly asking to consider these options and implement them (one of two).
@pjuarezd pjuarezd self-assigned this Dec 30, 2023
alistarle added a commit to alistarle/operator that referenced this issue Jan 5, 2024
@alistarle
Optionnally install CRDs in the operator helm chart
3f55e75 
Add installCRDs flag in the operator helm chart to be able
to not install the CRDs at the same time of the operator
itself.

Fix minio#1915
@alistarle alistarle mentioned this issue Jan 5, 2024
Closed
@alistarle
Copy link
Contributor

I made a proposition of a simple and not breaking implementation.

Moving the CRDs definitions in a "crds" directory of the chart will allow to use the built-in crd support of helm: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/ but it doesn't support upgrade or deletion.

Separate chart is a good idea but it can be breaking, or we should use helm subchart installed by default but even in that case I don't know how helm will handle upgrade to move from a monolitic chart to a main chart + subchart for CRDs.

@pjuarezd
Copy link
Member

pjuarezd commented Jan 5, 2024

I made a proposition of a simple and not breaking implementation.

Moving the CRDs definitions in a "crds" directory of the chart will allow to use the built-in crd support of helm: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/ but it doesn't support upgrade or deletion.

Separate chart is a good idea but it can be breaking, or we should use helm subchart installed by default but even in that case I don't know how helm will handle upgrade to move from a monolitic chart to a main chart + subchart for CRDs.

Right, we came to a similar conclusion, please check comment here #1553 (comment)

@pjuarezd pjuarezd mentioned this issue Jan 5, 2024
Closed
@allanrogerr
Copy link
Contributor

We will discuss this internally and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjuarezd pjuarezd

@ramondeklein ramondeklein

@cniackz cniackz

@dvaldivia dvaldivia

Labels
community triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optionnally install CRDs in the operator helm chart alistarle/operator
7 participants
@pjuarezd @gecube @alistarle @ramondeklein @cniackz @allanrogerr @dvaldivia