Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature and SHA to the Docker images #20270

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

ramondeklein
Copy link
Contributor

Add signature and SHA to the images to fix minio/operator#2229.

@ramondeklein
Copy link
Contributor Author

@aead @harshavardhana I'm not sure if I made the correct changes or if I am missing some secret. When I run TARGETARCH=amd64 RELEASE=RELEASE.2024-08-03T04-33-23Z docker build -f Dockerfile.release ., I get failures on the signature verification:

Dockerfile.release:32
--------------------
  31 |     # Verify binary signature using public key "RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGavRUN"
  32 | >>> RUN minisign -Vqm /go/bin/minio -x /go/bin/minio.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav && \
  33 | >>>     minisign -Vqm /go/bin/mc -x /go/bin/mc.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav
  34 |
--------------------
ERROR: failed to solve: process "/bin/sh -c minisign -Vqm /go/bin/minio -x /go/bin/minio.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav &&     minisign -Vqm /go/bin/mc -x /go/bin/mc.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav" did not complete successfully: exit code: 1

@harshavardhana
Copy link
Member

@aead @harshavardhana I'm not sure if I made the correct changes or if I am missing some secret. When I run TARGETARCH=amd64 RELEASE=RELEASE.2024-08-03T04-33-23Z docker build -f Dockerfile.release ., I get failures on the signature verification:

Dockerfile.release:32
--------------------
  31 |     # Verify binary signature using public key "RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGavRUN"
  32 | >>> RUN minisign -Vqm /go/bin/minio -x /go/bin/minio.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav && \
  33 | >>>     minisign -Vqm /go/bin/mc -x /go/bin/mc.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav
  34 |
--------------------
ERROR: failed to solve: process "/bin/sh -c minisign -Vqm /go/bin/minio -x /go/bin/minio.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav &&     minisign -Vqm /go/bin/mc -x /go/bin/mc.minisig -P RWTx5Zr1tiHQLwG9keckT0c45M3AGeHD6IvimQHpyRywVWGbP1aVSGav" did not complete successfully: exit code: 1

Looks like a temporary issue @ramondeklein

@harshavardhana harshavardhana merged commit b07c58a into master Aug 15, 2024
20 checks passed
@harshavardhana harshavardhana deleted the add-sig-sha-to-image branch August 15, 2024 15:48
@pschichtel
Copy link

awesome, so we expect the next release to "just work" ? when can we expect that release?

harshavardhana added a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error syncing 'minio/...': Tar file extraction failed for file index: 2, with: EOF when updating minio
3 participants