Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement args builder for removeIncompleteUpload #968

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

anjalshireesh
Copy link
Contributor

Introduced the new args class RemoveIncompleteUploadArgs (extends from
ObjectArgs and doesn't add any additional params) and added a new
method

MinioClient#removeIncompleteUpload(RemoveIncompleteUploadArgs args)

deprecating the existing method

MinioClient#removeIncompleteUpload(String bucketName, String objectName)

@anjalshireesh anjalshireesh force-pushed the remove-incomplete-upload branch from 7f036d6 to 46adeb8 Compare June 4, 2020 07:27
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/API.md Outdated Show resolved Hide resolved
Introduced the new args class `RemoveIncompleteUploadArgs` (extends from
`ObjectArgs` and doesn't add any additional params) and added a new
method

`MinioClient#removeIncompleteUpload(RemoveIncompleteUploadArgs args)`

deprecating the existing method

`MinioClient#removeIncompleteUpload(String bucketName, String objectName)`
@anjalshireesh anjalshireesh force-pushed the remove-incomplete-upload branch from 46adeb8 to 0821a33 Compare June 4, 2020 12:37
@anjalshireesh anjalshireesh requested a review from sinhaashish June 4, 2020 12:39
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit fdd00c7 into minio:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants