move xml parsing using SimpleXML #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
move-xml-parsing-to-SimpleXML
branch
2 times, most recently
from
191bc66 to
05a8bea
Compare
balamurugana
force-pushed
the
move-xml-parsing-to-SimpleXML
branch
2 times, most recently
from
eb17aa4 to
82cd6ce
Compare
nitisht
reviewed
Mar 5, 2020
There was a problem hiding this comment.
Build is failing, can you PTAL @balamurugana
/home/runner/work/minio-java/minio-java/api/src/main/java/io/minio/MinioClient.java:3253: error: cannot find symbol
private Iterator<Prefix> prefixIterator;
^
symbol: class Prefix
/home/runner/work/minio-java/minio-java/api/src/main/java/io/minio/MinioClient.java:3283: error: cannot find symbol
this.prefixIterator = new LinkedList<Prefix>().iterator();
^
symbol: class Prefix
/home/runner/work/minio-java/minio-java/api/src/main/java/io/minio/MinioClient.java:3410: error: cannot find symbol
private Iterator<Prefix> prefixIterator;
^
symbol: class Prefix
/home/runner/work/minio-java/minio-java/api/src/main/java/io/minio/MinioClient.java:3444: error: cannot find symbol
this.prefixIterator = new LinkedList<Prefix>().iterator();
^
symbol: class Prefix
4 errors
:api:compileJava FAILED
417c8b4 to
8916527
Compare
balamurugana
force-pushed
the
move-xml-parsing-to-SimpleXML
branch
3 times, most recently
from
2924d46 to
345dbfe
Compare
balamurugana
force-pushed
the
move-xml-parsing-to-SimpleXML
branch
from
345dbfe to
725ebe3
Compare
harshavardhana
previously approved these changes
Mar 14, 2020
balamurugana
dismissed stale reviews from kannappanr and harshavardhana
via
d41127e
balamurugana
force-pushed
the
move-xml-parsing-to-SimpleXML
branch
from
725ebe3 to
d41127e
Compare
This breaks backward compatibility
balamurugana
force-pushed
the
move-xml-parsing-to-SimpleXML
branch
from
d41127e to
e868fbf
Compare
harshavardhana
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks backward compatibility