refactor removeObjects #809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinSmile
force-pushed
the
refactor-removeObjects
branch
2 times, most recently
from
3b6db0b to
dea9335
Compare
KevinSmile
force-pushed
the
refactor-removeObjects
branch
from
dea9335 to
175b87b
Compare
|
close it as discussed in #810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor removeObjects (batch remove)
Issue to solve:
MinioClient.removeObjects() is kind of strange and of low efficiency.
minio-java/api/src/main/java/io/minio/MinioClient.java
Line 3004 in cd1109b
Details:
1. strange usage of Iterable
MinioClient.removeObjects() returns an Iterable.
This method is doing a DELETE job, but the actual delete job won't execute if you don't iterate over the returned Iterable-value (which will call
minio-java/api/src/main/java/io/minio/MinioClient.java
Line 3014 in cd1109b
(Call MinioClient.removeObjects() alone deletes nothing, which is strange).
2. improve generating batchDelete-objectList with java8-stream
(default batchSize is 1000)