Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper methods to build http client with JKS/PKCS12 certificates #1439

Merged
merged 10 commits into from
Apr 13, 2023

Conversation

dormanze
Copy link
Contributor

Users who use the minio client for the first time do not know how to write the SSL client code.
I suggest adding an TSL example.

examples/MinioClientWithTLS.java Outdated Show resolved Hide resolved
@dormanze dormanze changed the title examples:add TLS client example examples:add jks or p12 type certificate support Apr 12, 2023
api/src/main/java/io/minio/http/HttpUtils.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/http/HttpUtils.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/http/HttpUtils.java Outdated Show resolved Hide resolved
@balamurugana balamurugana changed the title examples:add jks or p12 type certificate support Add helper methods to create http client with JKS/PKCS12 certificates Apr 12, 2023
api/src/main/java/io/minio/http/HttpUtils.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/http/HttpUtils.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/http/HttpUtils.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/http/HttpUtils.java Outdated Show resolved Hide resolved
examples/MinioClientWithTLS.java Outdated Show resolved Hide resolved
@balamurugana
Copy link
Member

@dormanze Please fix CI failures

@dormanze
Copy link
Contributor Author

@dormanze Please fix CI failures

Copy that, fixed CI.

@balamurugana balamurugana changed the title Add helper methods to create http client with JKS/PKCS12 certificates Add helper methods to build http client with JKS/PKCS12 certificates Apr 13, 2023
@dormanze
Copy link
Contributor Author

@harshavardhana Please approve my pr.

@harshavardhana harshavardhana merged commit 884095b into minio:master Apr 13, 2023
@dormanze dormanze deleted the TLS branch April 14, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants