-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper methods to build http client with JKS/PKCS12 certificates #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
requested changes
Apr 11, 2023
dormanze
changed the title
examples:add TLS client example
examples:add jks or p12 type certificate support
Apr 12, 2023
balamurugana
requested changes
Apr 12, 2023
balamurugana
changed the title
examples:add jks or p12 type certificate support
Add helper methods to create http client with JKS/PKCS12 certificates
Apr 12, 2023
balamurugana
requested changes
Apr 13, 2023
@dormanze Please fix CI failures |
Copy that, fixed CI. |
balamurugana
approved these changes
Apr 13, 2023
balamurugana
changed the title
Add helper methods to create http client with JKS/PKCS12 certificates
Add helper methods to build http client with JKS/PKCS12 certificates
Apr 13, 2023
@harshavardhana Please approve my pr. |
harshavardhana
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who use the minio client for the first time do not know how to write the SSL client code.
I suggest adding an TSL example.