Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum elements into CompleteMultipartUploadOutput class #1377

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

mmadoo
Copy link
Contributor

@mmadoo mmadoo commented Oct 19, 2022

Using minio server with docker image minio/minio:RELEASE.2022-09-01T23-53-36Z when I do a mutipart upload, I receive the following response:

<CompleteMultipartUploadResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
	<Location>https://minio.xxx/myBucket/bigFile</Location>
	<Bucket>myBucket</Bucket>
	<Key>bigFile</Key>
	<ETag>&#34;d991cefbc7c54591517a7d17b5188c68-104&#34;</ETag>
	<ChecksumCRC32></ChecksumCRC32>
	<ChecksumCRC32C></ChecksumCRC32C>
	<ChecksumSHA1></ChecksumSHA1>
	<ChecksumSHA256></ChecksumSHA256>
</CompleteMultipartUploadResult>

This cause a warn log like

 Oct 18, 2022 1:02:21 AM io.minio.S3Base lambda$completeMultipartUploadAsync$12 WARNING: S3 service returned unknown XML for CompleteMultipartUpload REST API. <?xml version="1.0" encoding="UTF-8"?><CompleteMultipartUploadResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Location>https://minio.xxx/myBucket/bigFile</Location><Bucket>myBucket</Bucket><Key>bigFile</Key><ETag>&#34;d991cefbc7c54591517a7d17b5188c68-104&#34;</ETag><ChecksumCRC32></ChecksumCRC32><ChecksumCRC32C></ChecksumCRC32C><ChecksumSHA1></ChecksumSHA1<ChecksumSHA256></ChecksumSHA256></CompleteMultipartUploadResult>

This pull request add the missing Checksum elements in CompleteMultipartUploadOutput object.

Fixes #1376

harshavardhana
harshavardhana previously approved these changes Oct 19, 2022
Signed-off-by: Nicolas Trangosi <[email protected]>
@mmadoo mmadoo mentioned this pull request Oct 19, 2022
@balamurugana balamurugana changed the title Add missing elements in CompleteMultipartUploadOutput Add checksum elements into CompleteMultipartUploadOutput class Oct 19, 2022
@harshavardhana harshavardhana merged commit 328c49d into minio:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultipartUpload Response
3 participants