Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async client support #1308

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Mar 9, 2022

This commit comes with

  • Adds MinioAsyncClient class contains APIs returning CompletableFuture to execute them in future.
  • All APIs in MinioClient underneath uses APIs in MinioAsyncClient as base.
  • All low level S3 APIs in S3Base class return CompletableFuture and older APIs are deprecated.

Signed-off-by: Bala.FA [email protected]

@balamurugana balamurugana marked this pull request as draft March 9, 2022 09:52
@balamurugana balamurugana force-pushed the Add-async-support branch 29 times, most recently from bdb28d9 to a391c55 Compare March 16, 2022 11:32
@balamurugana balamurugana force-pushed the Add-async-support branch 5 times, most recently from 39ca98e to 62032f5 Compare March 23, 2022 01:53
@balamurugana balamurugana marked this pull request as ready for review April 4, 2022 03:13
@balamurugana balamurugana changed the title Add async support Add async client support Apr 4, 2022
@balamurugana balamurugana force-pushed the Add-async-support branch 2 times, most recently from 131d59d to 8b4f807 Compare April 21, 2022 06:48
anjalshireesh
anjalshireesh previously approved these changes Apr 22, 2022
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

api/src/main/java/io/minio/S3Base.java Outdated Show resolved Hide resolved
This commit comes with
* Adds `MinioAsyncClient` class contains APIs returning
  `CompletableFuture` to execute them in future.

* All APIs in `MinioClient` underneath uses APIs in
  `MinioAsyncClient` as base.

* All low level S3 APIs in `S3Base` class return `CompletableFuture`
  and older APIs are deprecated.

Signed-off-by: Bala.FA <[email protected]>
Signed-off-by: Bala.FA <[email protected]>
Signed-off-by: Bala.FA <[email protected]>
Signed-off-by: Bala.FA <[email protected]>
@harshavardhana harshavardhana merged commit 0b50a8a into minio:master Apr 27, 2022
@balamurugana balamurugana deleted the Add-async-support branch June 16, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants