-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async client support #1308
Merged
Merged
Add async client support #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
Add-async-support
branch
29 times, most recently
from
March 16, 2022 11:32
bdb28d9
to
a391c55
Compare
balamurugana
force-pushed
the
Add-async-support
branch
5 times, most recently
from
March 23, 2022 01:53
39ca98e
to
62032f5
Compare
balamurugana
force-pushed
the
Add-async-support
branch
from
April 4, 2022 02:52
66d5b1c
to
8fff64c
Compare
balamurugana
force-pushed
the
Add-async-support
branch
from
April 4, 2022 03:30
8fff64c
to
be8732f
Compare
balamurugana
force-pushed
the
Add-async-support
branch
from
April 5, 2022 02:23
be8732f
to
7df687c
Compare
anjalshireesh
requested changes
Apr 11, 2022
balamurugana
force-pushed
the
Add-async-support
branch
2 times, most recently
from
April 21, 2022 06:48
131d59d
to
8b4f807
Compare
anjalshireesh
previously approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor suggestion
This commit comes with * Adds `MinioAsyncClient` class contains APIs returning `CompletableFuture` to execute them in future. * All APIs in `MinioClient` underneath uses APIs in `MinioAsyncClient` as base. * All low level S3 APIs in `S3Base` class return `CompletableFuture` and older APIs are deprecated. Signed-off-by: Bala.FA <[email protected]>
Signed-off-by: Bala.FA <[email protected]>
Signed-off-by: Bala.FA <[email protected]>
Signed-off-by: Bala.FA <[email protected]>
balamurugana
force-pushed
the
Add-async-support
branch
from
April 26, 2022 03:12
8b4f807
to
1a8f449
Compare
harshavardhana
approved these changes
Apr 26, 2022
anjalshireesh
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit comes with
MinioAsyncClient
class contains APIs returningCompletableFuture
to execute them in future.MinioClient
underneath uses APIs inMinioAsyncClient
as base.S3Base
class returnCompletableFuture
and older APIs are deprecated.Signed-off-by: Bala.FA [email protected]