Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code property check optional in IamAwsProvider #1109

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Make code property check optional in IamAwsProvider #1109

merged 1 commit into from
Nov 11, 2020

Conversation

balamurugana
Copy link
Member

Fixes #1108

@balamurugana balamurugana marked this pull request as draft November 9, 2020 16:54
@balamurugana balamurugana marked this pull request as ready for review November 9, 2020 17:56
kannappanr
kannappanr previously approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the make-code-property-check-optional-in-IamAwsProvider branch from cb1f2fc to 68a56cf Compare November 10, 2020 05:55
@balamurugana balamurugana merged commit d49172e into minio:master Nov 11, 2020
@balamurugana balamurugana deleted the make-code-property-check-optional-in-IamAwsProvider branch November 11, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IamAwsProvider can't fetch ECS task role credentials
3 participants
@balamurugana @sinhaashish @kannappanr