Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add assume-role credential provider #1036

Merged
merged 1 commit into from
Sep 3, 2020
Merged

add assume-role credential provider #1036

merged 1 commit into from
Sep 3, 2020

Conversation

balamurugana
Copy link
Member

Fixes #817

@aalex21
Copy link

aalex21 commented Aug 11, 2020

Can we support the "ExternalId" parameter as part of AssumeRole Query Params ?
https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html

This will limit one minio client to be associated with one externalId !!

@balamurugana balamurugana force-pushed the add-assume-role-credential-provider branch from 3d8843e to caec179 Compare August 11, 2020 06:03
@balamurugana
Copy link
Member Author

Can we support the "ExternalId" parameter as part of AssumeRole Query Params ?
https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html

This will limit one minio client to be associated with one externalId !!

Sure. Added now.

@balamurugana balamurugana force-pushed the add-assume-role-credential-provider branch 3 times, most recently from 9171a84 to c564b98 Compare August 17, 2020 16:23
@balamurugana balamurugana force-pushed the add-assume-role-credential-provider branch 2 times, most recently from f795521 to 19cc439 Compare August 22, 2020 01:50
@balamurugana balamurugana mentioned this pull request Aug 26, 2020
Closed
@balamurugana balamurugana force-pushed the add-assume-role-credential-provider branch from 19cc439 to b7dee7f Compare September 1, 2020 08:16
anjalshireesh
anjalshireesh previously approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the add-assume-role-credential-provider branch from d0cd54b to 3c912ce Compare September 3, 2020 09:11
@balamurugana balamurugana mentioned this pull request Sep 3, 2020
Merged
@balamurugana balamurugana force-pushed the add-assume-role-credential-provider branch from 3c912ce to 6a9a454 Compare September 3, 2020 11:55
sinhaashish
sinhaashish approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

anjalshireesh
anjalshireesh approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit c94d8d9 into minio:master Sep 3, 2020
@balamurugana balamurugana deleted the add-assume-role-credential-provider branch September 3, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balamurugana @aalex21 @anjalshireesh @sinhaashish