Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication: Add replica metadata modification sync to Options #1491

Merged
merged 1 commit into from
May 17, 2021

Conversation

poornas
Copy link
Contributor

@poornas poornas commented May 14, 2021

No description provided.

Copy link
Contributor

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a docs perspective.

@klauspost
Copy link
Contributor

=== RUN   TestAddReplicationRule
Error:     replication_test.go:149: Test 3: Expected Priority must be unique. Replication configuration already has a rule with this priority, got priority must be unique. Replication configuration already has a rule with this priority
Error:     replication_test.go:149: Test 6: Expected Role ARN does not match existing configuration, got role ARN does not match existing configuration
Error:     replication_test.go:149: Test 8: Expected A rule exists with this ID, got a rule exists with this ID
--- FAIL: TestAddReplicationRule (0.00s)
=== RUN   TestEditReplicationRule
Error:     replication_test.go:323: Test 4: Expected The destination bucket must be same for all rules, got the destination bucket must be same for all rules
Error:     replication_test.go:323: Test 7: Expected Priority must be unique. Replication configuration already has a rule with this priority, got priority must be unique. Replication configuration already has a rule with this priority

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit f0518ca into minio:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants