Fix AWS STS url to https when using web identity token #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannappanr
approved these changes
Apr 14, 2020
harshavardhana
approved these changes
Apr 14, 2020
2 tasks
This was referenced May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes AWS STS url to https when using web identity token.
I'm using EKS ServiceAccount IAM auth for thanos deployment and thanos uses minio-go to access S3 bucket. There were thanos logs like below, which means minio-go failed to get temporary credentials when using web identity token file.
After digging into minio-go codes, I found error was returned in sts_web_identity.go#L143
And it was because of missing 'https://' in minio-go sts url, so I'm using my own custom build docker image by fixing it. It would be better to merge in upstream repository if there are not any exceptions :D