Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for Go runtime metrics #322

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Add types for Go runtime metrics #322

merged 4 commits into from
Dec 18, 2024

Conversation

klauspost
Copy link
Contributor

@klauspost klauspost commented Dec 18, 2024 •
edited
Loading

  • Adds realtime metrics type
  • Adds profile type
  • Remove legacy profile calls console :/

@klauspost
Add types for Go runtime metrics
ec787da 
* Adds realtime metrics type
* Adds profile type
* Remove legacy profile calls
harshavardhana
harshavardhana requested changes Dec 18, 2024
View reviewed changes
metrics.go Outdated Show resolved Hide resolved
@klauspost
Copy link
Contributor Author

Seems like console is using these old, unsafe profiling commands:

e:\gopath\pkg\mod\github.com\minio\[email protected]\api\client-admin.go:272:19: ac.Client.StartProfiling undefined (type *madmin.AdminClient has no field or method StartProfiling)
e:\gopath\pkg\mod\github.com\minio\[email protected]\api\client-admin.go:277:19: ac.Client.DownloadProfilingData undefined (type *madmin.AdminClient has no field or method DownloadProfilingData)

:(

@klauspost klauspost marked this pull request as draft December 18, 2024 16:29
@klauspost klauspost marked this pull request as ready for review December 18, 2024 16:55
@klauspost
Copy link
Contributor Author

Weird that non-generated code wasn't picked up.

klauspost added a commit to klauspost/mc that referenced this pull request Dec 18, 2024
@klauspost
Add runtime profile
508e85d 
Available on AIStor.

Requires minio/madmin-go#322

Lower minimum duration to 1 second. Useful (pretty much required) for traces.
@klauspost klauspost mentioned this pull request Dec 18, 2024
Merged
1 task
@harshavardhana
Copy link
Member

e:\gopath\pkg\mod\github.com\minio\[email protected]\api\client-admin.go:272:19: ac.Client.StartProfiling undefined (type *madmin.AdminClient has no field or method StartProfiling)

@ramondeklein @cesnietor

@harshavardhana harshavardhana merged commit 79a85c8 into minio:main Dec 18, 2024
6 checks passed
@ramondeklein ramondeklein mentioned this pull request Dec 18, 2024
Closed
@ramondeklein
Copy link
Contributor

@cesnietor I have created minio/console#3487 for fixing this.

@klauspost klauspost deleted the add-runtime-metrics branch December 18, 2024 21:43
harshavardhana pushed a commit to minio/mc that referenced this pull request Jan 2, 2025
@klauspost
Add go runtime profile type (#5098)
147852c 
Available on AIStor.

Requires minio/madmin-go#322

Lower minimum duration to 1 second. Useful (pretty much required) for traces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klauspost @harshavardhana @ramondeklein