Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fix regression on server address handling #405

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

aead
Copy link
Member

@aead aead commented Oct 24, 2023

This commit fixes a regression in how the kes server command handles the config file address.

With this commit, the server correctly uses the value from the --addr flag, if provided, and otherwise uses the value from the config file.

This commit fixes a regression in how the `kes server` command
handles the config file address.

With this commit, the server correctly uses the value from the `--addr`
flag, if provided, and otherwise uses the value from the config file.

Signed-off-by: Andreas Auernhammer <[email protected]>
@aead aead requested a review from kannappanr October 24, 2023 20:19
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aead aead merged commit b2443e0 into master Oct 24, 2023
9 checks passed
@aead aead deleted the config-addr-regression branch October 24, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants