DOCS-690, DOCS-707: Release updates #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djwfyi
approved these changes
Feb 3, 2023
|
|
||
| The MinIO Tenant Console Audit Log feature is scheduled for deprecation and removal in an upcoming release. | ||
|
|
||
| You can instead use any webhook-capable database or logging service to capture :ref:`audit logs <minio-logging-publish-audit-logs>` from the Tenant. |
There was a problem hiding this comment.
I suggest a different opening phrase:
As an alternative, use ...
| The MinIO Tenant Console Audit Log feature is scheduled for deprecation and removal in an upcoming release. | ||
| MinIO recommends disabling this feature in preparation for this change. | ||
|
|
||
| You can instead use any webhook-capable database or logging service to capture :ref:`audit logs <minio-logging-publish-audit-logs>` from the Tenant. |
There was a problem hiding this comment.
If you change it in managing-deployment, use similar phrasing here.
| The Tenant Prometheus pod feature is scheduled for deprecation and removal in an upcoming release. | ||
| MinIO recommends setting this value to ``false`` in preparation for this change. | ||
|
|
||
| You can instead use any Prometheus service deployed within the Kubernetes cluster or externally to :ref:`capture Tenant metrics <minio-metrics-collect-using-prometheus>`. |
There was a problem hiding this comment.
Same as the other two similar sentences. Be consistent in the the phrasing if you change them.
|
|
||
| .. important:: | ||
|
|
||
| The Tenant Prometheus pod feature is scheduled for deprecation and removal in an upcoming release. |
There was a problem hiding this comment.
This is probably fine in passive, but maybe:
MinIO plans to deprecate and remove the Tenant Prometheus pod feature in an upcoming release.
or
We plan to ...
| - Select the storage class and requested capacity associated to the PVC generated to support Prometheus. | ||
|
|
||
| * - Storage Size | ||
| - Specify the amount of size of storage to make available for Prometheus. |
There was a problem hiding this comment.
Either amount of or size of, but not both.
| - Specify the amount of size of storage to make available for Prometheus. | ||
|
|
||
| * - :guilabel:`SecurityContext` | ||
| - The MinIO Operator assigns this Security Context for the Prometheus pod |
| - The MinIO Operator assigns this Security Context for the Prometheus pod | ||
|
|
||
| You can modify the Security Context to run the associated pod commands using a different User, Group, FsGroup, or FSGroupChangePolicy. | ||
| You can also direct the pod to not run commands as the Root user. |
There was a problem hiding this comment.
Consider monotyping Root?
Maybe also the User, Group ... list in the previous line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #690
Closes #707
Partially addresses scheduled removal of Console Audit Log and Tenant Prometheus deployments
Staged: