New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cert-manager documentation #1317

Merged

djwfyi merged 11 commits into main from cert-manager

Oct 1, 2024

Collaborator

djwfyi commented Sep 11, 2024

Adds cert-manager docs for Kubernetes outputs.

Closes #1245

Partially addresses #1273

Staged:

djwfyi requested review from feorlen, Bradamant3 and ravindk89

September 11, 2024 20:32

djwfyi self-assigned this

ravindk89 requested changes

View reviewed changes

Collaborator

ravindk89 left a comment

I think we need to re-structure a bit. I'll do a closer pass on content after that

source/operations/cert-manager.rst Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

djwfyi force-pushed the cert-manager branch from bcfdde0 to fa353c6 Compare

September 17, 2024 17:55

feorlen reviewed

View reviewed changes

source/includes/k8s/deploy-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

feorlen reviewed

View reviewed changes

source/operations/network-encryption.rst Outdated Show resolved Hide resolved

feorlen requested changes

View reviewed changes

Collaborator

feorlen left a comment

Noted a couple typos, plus one thing I didn't understand. Maybe it's me, however.

ravindk89 requested changes

View reviewed changes

Collaborator

ravindk89 left a comment

Much improved - feedback given

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-tenants.rst Show resolved Hide resolved

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

source/operations/network-encryption.rst Outdated Show resolved Hide resolved

djwfyi force-pushed the cert-manager branch from 54925e5 to bca3274 Compare

September 20, 2024 20:05

djwfyi added the blocked label

Collaborator Author

djwfyi commented Sep 27, 2024

This PR is block until we get an updated graphic from the design team.

djwfyi force-pushed the cert-manager branch from 2c20d88 to 90ae3b5 Compare

September 30, 2024 18:00

djwfyi requested a review from ravindk89

September 30, 2024 18:01

djwfyi removed the blocked label

Bradamant3 reviewed

View reviewed changes

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

Bradamant3 reviewed

View reviewed changes

source/operations/cert-manager.rst Outdated Show resolved Hide resolved

Bradamant3 reviewed

View reviewed changes

Collaborator

Bradamant3 left a comment

Not explicitly requesting changes, but now you know about a fiddly thing I tend to catch ;)
Also apologies for stray single comments outside the purview of this review.

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

source/operations/cert-manager/cert-manager-operator.rst Outdated Show resolved Hide resolved

ravindk89 approved these changes

View reviewed changes

Collaborator

ravindk89 left a comment

I'll defer to @Bradamant3 on the addressing of that set of comments, but from a structure/high level this looks solid enough for us to move forward.

source/operations/cert-manager/cert-manager-tenants.rst Outdated Show resolved Hide resolved

Bradamant3 approved these changes

View reviewed changes

Collaborator

Bradamant3 left a comment

In case you need it, LGTM

djwfyi added 11 commits

October 1, 2024 16:05


          Starting to add cert manager info

bdd1fd0


          Adds cert-manager documentation for kubernetes outputs

a2f6475

Closes #1245

Partially addresses #1273


          Restructing cert-manager docs

1054e0d


          Build error and adding reference to deployment page

41b50c0


          Some missed PR feedback newly applied

4e2506c


          Applying additional PR feedback

0134e9d


          Applying another round of PR feedback

ff4e5f8


          Adding a section on migrating existing Operator to use cert-manager

c5611d2


          Updating graphic with new image

01c1958


          applying PR feedback

ee2d2cc


          Numbering issue noted in PR feedback

fb4c6d8

djwfyi force-pushed the cert-manager branch from a008bd6 to fb4c6d8 Compare

October 1, 2024 20:05

djwfyi merged commit ca34aa7 into main

djwfyi deleted the cert-manager branch

October 1, 2024 20:06

Bradamant3 added a commit that referenced this pull request


          copy and edit include content for single-drive deploy on linux

af37132

add moar include content

fix numbering AGAIN, list syntax for include and copied-into-parent

Updating encryption pages for KES API (#1333)

Our preferred method for authenticating from MinIO to KES is with an API
identity. This PR updates encryption docs to reflect this.

Closes #1280

Add cert-manager documentation (#1317)

Adds cert-manager docs for Kubernetes outputs.

Closes #1245

Partially addresses #1273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet