Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Exclude Folders & Exclude Prefixes support #2973

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Aug 1, 2023

fixes #2417

What does this do?

Added Exclude Folders & Exclude Prefixes support to Create Bucket & Bucket details pages

How does it look?

Screenshot 2023-07-31 at 22 08 08 Screenshot 2023-07-31 at 22 08 01 Screenshot 2023-07-31 at 22 07 26 Screenshot 2023-07-31 at 22 07 21

@prakashsvmx
Copy link
Member

@bexsoft
When versioning exclusion is applied on a locking bucket, it errors out.
I think it should not be functional for locking enabled bucket.

{
    "code": 500,
    "detailedMessage": "error setting versioning for bucket: An Object Lock configuration is present on this bucket, versioning cannot be suspended.",
    "message": "an error occurred, please try again"
}

Input.

image

@bexsoft
Copy link
Collaborator Author

bexsoft commented Aug 2, 2023

@bexsoft When versioning exclusion is applied on a locking bucket, it errors out. I think it should not be functional for locking enabled bucket.

{
    "code": 500,
    "detailedMessage": "error setting versioning for bucket: An Object Lock configuration is present on this bucket, versioning cannot be suspended.",
    "message": "an error occurred, please try again"
}

Input.

Added extra validations to avoid this behavior

Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM 👍

@cniackz
Copy link
Collaborator

cniackz commented Aug 2, 2023

Test Integration Tests with Latest Distributed MinIO will pass when MinIO gets these API changes. If it does not, I will be updating our test to match with new API changes. But for now the suggestion is to merge this PR and let the code be included under minio repo.

@bexsoft
Copy link
Collaborator Author

bexsoft commented Aug 2, 2023

For the missing Integration test, this change must be integrated in MinIO server in order to get it passing (This is related to a change in versioning API that is not present yet in MinIO server).

We will be monitoring this once a new Console release is made.

@bexsoft bexsoft merged commit 49f856b into minio:master Aug 2, 2023
@bexsoft bexsoft deleted the exclude-prefixes branch August 2, 2023 19:35
@djwfyi djwfyi mentioned this pull request Aug 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Web Console add new setting about version exclude-prefixes
3 participants