Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Share Object logic to use Access Keys #2827

Merged
merged 1 commit into from
May 24, 2023

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 23, 2023

fixes #922

What does this do?

Changed Share Object Logic to use access keys instead of console login key. This is first step for this new change, as second phase we will auto generate auto expiring service accounts

How does it look?

Before:
Screenshot 2023-05-23 at 9 41 15 AM

After:
Screenshot 2023-05-22 at 18 19 59
Screenshot 2023-05-22 at 18 19 47
Screenshot 2023-05-22 at 18 19 43
Screenshot 2023-05-22 at 18 19 32
Screenshot 2023-05-22 at 18 19 24

@bexsoft bexsoft self-assigned this May 23, 2023
@bexsoft bexsoft force-pushed the share-link branch 3 times, most recently from e9e824d to f2dc101 Compare May 23, 2023 03:09
@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label May 23, 2023
@cesnietor
Copy link
Collaborator

Could we add something like An Access Key with privileges for current user is required to sign this URL (adding the for current user) or something like that? Just to be clear that even being an admin won't list other service accounts (made me think that).

@cesnietor
Copy link
Collaborator

I found that selecting 0 days, 0 hours, and 0 minutes hangs the UI.
Screenshot 2023-05-23 at 9 40 29 AM

swagger.yml Show resolved Hide resolved
@bexsoft bexsoft requested a review from reivaj05 May 23, 2023 21:40
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label May 23, 2023
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LTM.
It now gives the option to list user's service accounts or use other one by just typing it.

Screenshot 2023-05-23 at 3 37 21 PM

Also shows a validation error if 0 days, 0 minutes and 0 minutes

@dvaldivia dvaldivia merged commit 7a9b775 into minio:master May 24, 2023
@dvaldivia dvaldivia deleted the share-link branch May 24, 2023 17:52
@grubjack
Copy link

grubjack commented Jun 1, 2023

trying to share a file under LDAP user with consoleAdmin permissions and get the error:

{"Code":"XMinioAdminNoSuchUser","Message":"The specified user does not exist. (Specified user does not exist)","Resource":"/minio/admin/v3/list-service-accounts","RequestId":"176498EB2822B945","HostId":"dd90..."}

under regular LDAP user get the error:

{"Code":"AccessDenied","Message":"Access Denied.","Resource":"/minio/admin/v3/list-service-accounts","RequestId":"176498F6A04CC8B9","HostId":"dd90..."}

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links expire within an hour when sharing from web interface regardless of the value set
5 participants