Skip to content

Commit

Permalink
Uniformly handle byline across all text types
Browse files Browse the repository at this point in the history
Poem already has `p.byline`, but narrative had `p.citation` (which is
never referenced in the CSS), and drama had no byline at all. The
_Raisin in the Sun_ demo file was inserting the byline directly into the
page content itself. (This commit removes that now-duplicate content.)

So now all templates have a `p.byline`.

Note that poems do not have "by" in front of the author's name, unlike
narratives and drama. The history of that choice in the Ed project is
unclear, but it will continue preserved here.
  • Loading branch information
karlstolley committed Sep 18, 2019
1 parent 99135ac commit ca208bf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions _layouts/drama.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@

<article class="drama">
<h1 class="text-title">{{ page.title }}</h1>
<p class="byline">by {{ page.author }}</p>
{{ content }}
</article>
2 changes: 1 addition & 1 deletion _layouts/narrative.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

<article class="narrative">
<h1 class="text-title">{{ page.title }}</h1>
<p class="citation"> by {{ page.author }}</p>
<p class="byline">by {{ page.author }}</p>
{{ content }}
</article>
2 changes: 0 additions & 2 deletions _texts/raising.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ source: "Hansberry, Lorraine, and Robert Nemiroff. A Raisin in the Sun. Rep Rei

---

<p class="citation"> by {{ page.author }}</p>

(excerpt)

MAMA: Son—how come you talk so much 'bout money?
Expand Down

0 comments on commit ca208bf

Please sign in to comment.