Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure images to Azure_Icons_v18 #980

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ebbypeter
Copy link

  • Add Azure_Icons to v18
  • Update Contributing.md file to include Azure specific instructions
  • Add DevContainer.json file to make further development easier
  • Thanks @rfernandezdo for the initial v12 commit and approach

- Add Azure_Icons to v18
- Update Contributing.md file to include Azure specific instructions
- Add DevContainer.json file to make further development easier
- Thanks @rfernandezdo for the initial v12 commit and approach
@ebbypeter
Copy link
Author

@mingrammer This PR is to supersede other Azure related PRs (#695, #696, #864 & #865). Added/Updated the images to the latest v18 Azure icons.

@ebbypeter
Copy link
Author

The icons are sourced from Microsoft Azure architecture icons

@ebbypeter
Copy link
Author

This PR should take care of issues #750, #669, #623, #448, #137

@ebbypeter
Copy link
Author

@mingrammer Any update / feedback on this PR? Anything that needs to be done for this?

1 similar comment
@ebbypeter
Copy link
Author

@mingrammer Any update / feedback on this PR? Anything that needs to be done for this?

@ebbypeter
Copy link
Author

Who have write access to this repo?

@mingrammer
Copy link
Owner

Sorry for the late reply. I was so busy these days. I'll review it in 2 days.

@ebbypeter
Copy link
Author

This PR should take care of #982 #1001

@ebbypeter
Copy link
Author

ebbypeter commented Jul 1, 2024

@mingrammer following up - any updates on this?

@tb102122
Copy link
Contributor

tb102122 commented Nov 7, 2024

@ebbypeter can you please resolve the conflicts

@ebbypeter
Copy link
Author

ebbypeter commented Nov 12, 2024

done... the branch is now in sync with the main. @tb102122

@gabriel-tessier gabriel-tessier added the area/provider/azure Azure provider label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants