fix(diagrams): Set a dummy filename to prevent raise error when both … #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name and filename are not provided(#203)
mingrammer
reviewed
Jul 22, 2020
Update default name to "diagrams_image"
Update unit test to reflect the file name change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…name and filename are not provided(#203)
I added a unit test and linked to the issue it may be more clear than a long description.
Why I did it this way: I think that it's more simple (for usage and human users) to just generate a file with a dummy name than raising an error, as it can generate frustration as people may just open an issue and complain that it's not working.