Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fluent Bit #154

Merged
merged 2 commits into from
May 20, 2020
Merged

Add Fluent Bit #154

merged 2 commits into from
May 20, 2020

Conversation

ghyde
Copy link
Contributor

@ghyde ghyde commented May 19, 2020

Add Fluent Bit to onprem logging.

@mingrammer
Copy link
Owner

Please resolve the conflicts :)

@mingrammer mingrammer added area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request labels May 20, 2020
@ghyde
Copy link
Contributor Author

ghyde commented May 20, 2020 •
edited
Loading

@mingrammer I updated my branch to resolve the merge conflicts.

mingrammer
mingrammer approved these changes May 20, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@mingrammer mingrammer merged commit 91f3f36 into mingrammer:master May 20, 2020
@ghyde ghyde deleted the fluentbit branch May 20, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghyde @mingrammer