Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add player position and look packet #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paralin
Copy link

@paralin paralin commented Oct 9, 2021

The final packet sent when connecting:

see https://wiki.vg/Protocol#Player_Position_And_Look_.28clientbound.29

The final packet sent when connecting.

Signed-off-by: Christian Stewart <[email protected]>
@robinbraemer
Copy link
Member

Thanks for your contribution!

Could you explain why Gate needs to know about this packet and why it is useful for the proxy?

@paralin
Copy link
Author

paralin commented Oct 9, 2021

It's the final packet in the join sequence. You can use this to create a "lightweight server" by sending the "set player position" packet just after the auth sequence. See this branch: https://github.com/paralin/minekube-gate/tree/paralin

@nuriofernandez
Copy link
Contributor

It looks great but maybe it makes the maintenance harder. Could this be a module that you can decide to use or not?

@robinbraemer robinbraemer added enhancement New feature or request (not a bug) good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested labels Feb 3, 2022
@robinbraemer
Copy link
Member

robinbraemer commented Feb 3, 2022

I have not tested this and from what I understand you mean that if Gate would send this packet after auth then the player would have a shorter loading screen and see the world more quickly.

Should Gate send this packet only once or every time the player joins/switches the backend server?
Does it not matter which coordinates we send in this packet since it gets sent by the backend server anyways?

I agree @xxnurioxx, this could be a feature that users can enable or disable in the config.
If we add this packet, we also need to support the packet IDs starting from Minecraft 1.7 in the state package.

@luiz-otavio
Copy link
Contributor

I have not tested this and from what I understand you mean that if Gate would send this packet after auth then the player would have a shorter loading screen and see the world more quickly.

Should Gate send this packet only once or every time the player joins/switches the backend server? Does it not matter which coordinates we send in this packet since it gets sent by the backend server anyways?

I agree @xxnurioxx, this could be a feature that users can enable or disable in the config. If we add this packet, we also need to support the packet IDs starting from Minecraft 1.7 in the state package.

I agree with him, this would be great for high cracked network servers like most brazillian servers, because we could make some agree of requirement, authorization, checking or whatever we could do in a light-weight server.
This specific case would be just pulled out only once in player joins.

@paralin
Copy link
Author

paralin commented Feb 3, 2022

Should Gate send this packet only once or every time the player joins/switches the backend server?

It can be used to dismiss the loading screen, so possibly sending it when switching backend servers could be helpful, especially if you wanted to add a custom loading screen.

Does it not matter which coordinates we send in this packet since it gets sent by the backend server anyways?

Correct, there doesnt' seem to be any validation on the client end.

The main purpose of adding this packet is to make a 'lightweight server' where you have no backend server at all.

This is of course useful to make custom loading state views, while determining which backend server to connect to.

@robinbraemer robinbraemer added wontfix This will not be worked on and removed help wanted Extra attention is needed question Further information is requested labels Mar 2, 2022
@robinbraemer robinbraemer added this to the Nonurgent milestone Mar 2, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04d5cd8
Status: ✅  Deploy successful!
Preview URL: https://bac13e5c.gate-minekube.pages.dev

View logs

@robinbraemer robinbraemer added the priority/low Low priority task label Mar 17, 2023
@robinbraemer robinbraemer removed this from the Nonurgent milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (not a bug) good first issue Good for newcomers priority/low Low priority task wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants