Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dev == Live evaluate to almost true :) #50

Merged
merged 4 commits into from
Jun 12, 2022
Merged

Make Dev == Live evaluate to almost true :) #50

merged 4 commits into from
Jun 12, 2022

Conversation

ldb
Copy link
Contributor

@ldb ldb commented Jun 11, 2022

No description provided.

@ldb ldb requested review from akkbng and jgraeger June 11, 2022 19:24
Copy link
Contributor

@akkbng akkbng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jgraeger jgraeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but apply the requested changes

kratos/values-live.yaml Outdated Show resolved Hide resolved
login:
ui_url: https://auth-example.api.live.mindtastic.lol/login
lifespan: 15m
ui_url: https://auth-example.api.dev.mindtastic.lol/login
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ui_url: https://auth-example.api.dev.mindtastic.lol/login
ui_url: https://auth-example.api.live.mindtastic.lol/login

kratos/values-live.yaml Outdated Show resolved Hide resolved
kratos/values-live.yaml Outdated Show resolved Hide resolved
ldb and others added 3 commits June 12, 2022 13:03
Co-authored-by: Johannes Gräger <[email protected]>
Co-authored-by: Johannes Gräger <[email protected]>
Co-authored-by: Johannes Gräger <[email protected]>
@ldb ldb merged commit ca40125 into main Jun 12, 2022
@ldb ldb deleted the chore/dev-live branch June 12, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants