Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update predict result model due to mindsdb changes #16

Closed
wants to merge 9 commits into from

Conversation

bachng2017
Copy link
Contributor

change the way to use predictor, fix #6

@bachng2017
Copy link
Contributor Author

bachng2017 commented Jan 6, 2023

seems that the latest mindsdb core does not work with existed implement anymore so we've change the table materialization code a little bit
for now, we've removed the predictor_name configuration. Another implement is parameterize the WHERE condition, so we could keep predictor_name as an parameters also.
do you have other suggestions ?

@bachng2017
Copy link
Contributor Author

bachng2017 commented Jan 6, 2023

or maybe, change the model to this is easier to understand

{{
config(
  materialized='table',
  integration='mindsdb_trino',
  origin_data = 'origin_data as t',
  filter='t.dt > LATEST'
)
}}
SELECT p.*
FROM predictor as p

which compiled into

SELECT p.*
FROM predictor as p
JOIN origin_data as t
WHERE t.dt > LATEST

@bachng2017 bachng2017 marked this pull request as draft January 7, 2023 01:34
@bachng2017 bachng2017 force-pushed the fix_table_materialization branch 2 times, most recently from 939b571 to cf00a53 Compare January 8, 2023 13:27
@bachng2017 bachng2017 marked this pull request as ready for review January 9, 2023 08:42
@bachng2017 bachng2017 marked this pull request as draft January 10, 2023 12:27
@bachng2017
Copy link
Contributor Author

seems that again, the latest mindsdb has prohibit something like this

select * from predictor join data

force to change to this again

select * from data join predictor

@bachng2017 bachng2017 force-pushed the fix_table_materialization branch 2 times, most recently from 22c94fc to 23729b9 Compare January 10, 2023 23:15
@bachng2017
Copy link
Contributor Author

need to clean up this MR

@bachng2017 bachng2017 closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the way to use predictor
1 participant