Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: 👷 add lint and deployment workflows #23

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

Despprie
Copy link
Collaborator

PR Details

Description

Improve code quality assurance with lint and cypress tests on pull requests and add automation for npm package deployment on release (can also publish/remove beta with a dispatch workflow)

This is the proposed workflow:

  • Create a beta tag when needed (vX.Y.Z-beta) and publish it using the deploy-beta workflow
  • Remove the beta tag when needed using the remove-beta workflow
  • Create a tag (vX.Y.Z) and a release using that tag to trigger the deploy workflow

When creating a tag, make sure to also change the version in package.json accordingly

A repository variable storing the npm authentication token named NPM_TOKEN must be created

Related Issue

None

Motivation and Context

Having strong automated workflows can save a lot of time for developers

How Has This Been Tested

Tested the workflows on a private repository

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added type hints (flow) to cover my changes.
  • All new and existing tests passed.

@AbdelfattahSekak AbdelfattahSekak merged commit e300853 into refactoring Jul 21, 2023
2 checks passed
@Despprie Despprie deleted the github-actions branch August 3, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants