Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/usr/local/bin directory is not guaranteed to exist #60

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Dec 2, 2021

I was running the tfmigrate tests and they failed because my machine doesn't have a /usr/local/bin directory. /bin should always be there, so we can use that instead.

@minamijoyo
Copy link
Owner

Hi @bouk, Thank you for the patch!

The test on ubuntu-latest was failed. It looks related in #18. What OS do you use?

@bouk
Copy link
Contributor Author

bouk commented Dec 3, 2021

ah I see, you ran into this before. I can change it to /usr/bin.

I use macOS, which doesn't have that directory by default.

/bin is a symlink on Ubuntu
Copy link
Owner

@minamijoyo minamijoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@minamijoyo minamijoyo merged commit f3fb904 into minamijoyo:master Dec 3, 2021
@minamijoyo
Copy link
Owner

@bouk Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants