Add role_arn to S3StorageConfig #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RichiCoder1 I've just added it, but not tested. Could you test this branch? |
|
@RichiCoder1 Do you have any time for testing this? An upcoming change I'm planning maybe need some refactoring and will conflict with this. |
|
Apologies, I haven't! Had a shift in work that carried me away. I'll try and get to it this weekend. |
|
Belated, but seems to be functioning as intended! |
|
@RichiCoder1 Thank you for your confirmation! Released it in v0.2.8 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32