Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade aws-sdk-go to v1.55.5 to use aws sso shared config #188

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

tk3fftk
Copy link
Contributor

@tk3fftk tk3fftk commented Nov 6, 2024

This pull request includes an update to the go.mod file to upgrade the version of the AWS SDK.

Dependencies update:

  • go.mod: Upgraded github.com/aws/aws-sdk-go from version v1.43.22 to v1.55.5.
  • it resolves an issue with aws sso
$ AWS_PROFILE=super-profile ../../../../../tfmigrate plan
2024/11/06 10:23:19 [INFO] Attempting to use session-derived credentials
2024/11/06 10:23:19 [INFO] Successfully derived credentials from session
2024/11/06 10:23:19 [INFO] AWS Auth provider used: "SSOProvider"
2024/11/06 10:23:20 [INFO] [runner] no unapplied migrations

Background

  • tfmigrate get an s3 client error with aws sso shared configuration (sso-session section) like below
$ AWS_PROFILE=super-profile ../../../../../tfmigrate plan
2024/11/06 09:45:38 [INFO] Attempting to use session-derived credentials
failed to new s3 client: Error creating AWS session: profile "super-profile" is configured to use SSO but is missing required configuration: sso_region, sso_start_url
[sso-session some-session]
sso_start_url = https://hogehoge.awsapps.com/start
sso_region = ap-northeast-1
sso_registration_scopes = sso:account:access

[profile super-profile]
sso_session = some-session
sso_account_id = 1111111111111
sso_role_name = DeveloperAccess
region = ap-northeast-1

@minamijoyo minamijoyo merged commit 980c182 into minamijoyo:master Nov 6, 2024
9 checks passed
@minamijoyo
Copy link
Owner

@tk3fftk Thank you for the fix! I'll cut a new release in a few days.

@tk3fftk tk3fftk deleted the fix/sso branch November 6, 2024 05:08
@minamijoyo
Copy link
Owner

The v0.3.25 has been shipped 🚢

@tk3fftk
Copy link
Contributor Author

tk3fftk commented Nov 6, 2024

super fast! thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants