Add support for Terraform v1.6 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minamijoyo
force-pushed
the
tf-1.6
branch
3 times, most recently
from
3ecce3e to
4d5e981
Compare
Starting from Terraform v1.6, the s3 backend configuration has changed, and the tfmigrate acceptance test fails. I suspect that the authentication mechanism may have been changed with the migration to aws-sdk-go-v2; I have tried a few things and found that I can authenticate by specifying the `iam_endpoint`. The `iam_endpoint` argument has been deprecated since Terraformv1.6. It is recommended to use the newly added `endpoints` argument, though, for running tests on multiple Terraform versions, the test settings must remain compatible with the older versions. This is a test-only issue, so I'll use the deprecated `iam_endpoint` for now. In the future, we should change the backend configuration depending on the Terraform version.
SwitchBackToRemoteFuncError tests verify error messages, but the error message for missing bucket key in the s3 backend differs depending on the Terraform version. Define a helper function to hide the difference.
The hashicorp/go-version returns false when comparing pre-releases, for example 1.6.0-rc1 >= 0.13. This is counter-intuitive for determining the presence or absence of a feature, so remove the pre-release information before comparing.
minamijoyo
force-pushed
the
tf-1.6
branch
3 times, most recently
from
a6096e9 to
9adfe7e
Compare
minamijoyo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All fixes we needed are related to tests: