Avoid using the AWS provider for acceptance tests #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect localstack is the reason why acceptance tests are slow and unstable. It's hard to completely eliminate localstack due to the s3 backend dependency, but we can avoid using the AWS provider whenever possible.
minamijoyo
added a commit
that referenced
this pull request
Dec 23, 2022
We have fixed acceptance tests in #116 Unit tests aren't required, but they tend to be copied and pasted, so fix them in the same way for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect localstack is the reason why acceptance tests are slow and unstable. It's hard to completely eliminate localstack due to the s3 backend dependency, but we can avoid using the AWS provider whenever possible.