Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL tests #695

Merged
merged 7 commits into from
Aug 19, 2021
Merged

DSL tests #695

merged 7 commits into from
Aug 19, 2021

Conversation

lovro-bikic
Copy link
Member

Adds tests for DSL.

This PR is a bit bigger because in order to achieve testing custom tasks for DSL, I wanted to isolate all specs so that they don't affect each other. Before, if one spec changed the configuration or added a new rake task, these changes would be visible in other specs. With the changes in this PR, each spec should now hopefully be isolated, and one spec's changes shouldn't affect other specs.

This PR also added Gemfile.lock to version control. The reasoning is outlined here, but the specific issue which prompted me into doing this is GA failing because it installed different versions of gems than those which I had locally (you can see the failing test run here).

@lovro-bikic lovro-bikic added this to the 1.3.0 milestone Aug 19, 2021
@lovro-bikic lovro-bikic requested a review from d4be4st August 19, 2021 10:24
@lovro-bikic lovro-bikic merged commit e294982 into master Aug 19, 2021
@lovro-bikic lovro-bikic deleted the feature/dsl-tests branch August 19, 2021 13:26
@lovro-bikic lovro-bikic mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants