Application tests #688
Merged
Application tests #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4be4st
approved these changes
Aug 14, 2021
lovro-bikic
commented
Aug 14, 2021
Comment on lines
+14
to
+19
| # :nocov: | ||
| def run | ||
| Rake.application = self | ||
| super | ||
| end | ||
| # :nocov: |
There was a problem hiding this comment.
I removed this method from simplecov coverage because there's no easy way to test this without invoking a task.
| @top_level_tasks << :debug_configuration_variables | ||
| @top_level_tasks << :run_commands | ||
|
|
||
| @top_level_tasks << 'debug_configuration_variables' |
There was a problem hiding this comment.
All @top_level_tasks are strings so I modified the default task names. It worked before because Rake calls to_s on a task name (ref)
| @@ -38,48 +41,53 @@ def minafile | |||
| end | |||
|
|
|||
| def version | |||
| ['--version', '-V', | |||
There was a problem hiding this comment.
The below code doesn't touch the logic, only style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for application class, mainly what happens when you set a command-line option.