Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling #44

Merged
merged 9 commits into from
Sep 14, 2017
Merged

Styling #44

merged 9 commits into from
Sep 14, 2017

Conversation

mimizotti
Copy link
Owner

#log

Description of Changes Made: There are a lot of things happening in this branch. First, I had to change some tests because some tests couldn't find the right button (due to the persistent nav bar). Furthermore, I added the session#destroy method so I could test the logout button (issue #20 / user story #11.

Anticipated Code Effects: There are definitely some conflicts in this branch.
(Would this merge affect any other piece of our code?)

Reviewer: @rickyamparo

@rickyamparo
Copy link
Collaborator

@mimilettd I resolved some conflicts that were not saved. These were conflicts that you resolved locally but that github did not save for whatever reason. Everything looks good and thanks for not only working so hard on this styling but for walking us through all of it!

@rickyamparo rickyamparo merged commit 9706d80 into master Sep 14, 2017
@rickyamparo rickyamparo deleted the styling branch September 16, 2017 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants