Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some TimeArray performance problems on 1.8 #911

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

davidanthoff
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #911 (dc61778) into master (aac4868) will decrease coverage by 0.00%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   84.56%   84.56%   -0.01%     
==========================================
  Files          40       40              
  Lines        3882     3881       -1     
==========================================
- Hits         3283     3282       -1     
  Misses        599      599              
Flag Coverage Δ
unittests 84.56% <89.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/time_arrays.jl 93.43% <88.88%> (-0.02%) ⬇️
src/mcs/montecarlo.jl 88.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac4868...dc61778. Read the comment docs.

@lrennels lrennels merged commit 1d9c36e into master Jul 21, 2022
@lrennels lrennels deleted the perf-timearray branch July 21, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants