Unique Backup Parameter Names #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrennels
changed the title
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
==========================================
+ Coverage 84.52% 84.56% +0.03%
==========================================
Files 40 40
Lines 3878 3881 +3
==========================================
+ Hits 3278 3282 +4
+ Misses 600 599 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles issue #865
When a connector component is added using backup data, the parameter name for the backup data is a model parameter (unshared) that was getting overwritten if the destination component had the same destination parameter name as another. This PR makes sure the added model parameter has a unique name.
Should we consider a check in
add_model_param!to make sure a given parameter does not yet exist in the model, or is overwriting sometimes desired?