Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a default Symbol or String #874

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Allow setting a default Symbol or String #874

merged 5 commits into from
Nov 17, 2021

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Nov 15, 2021

Handles #873 and allows us to set Symbols or Strings as defaults.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #874 (943fd46) into master (5c683a5) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   84.34%   84.28%   -0.06%     
==========================================
  Files          40       40              
  Lines        3794     3799       +5     
==========================================
+ Hits         3200     3202       +2     
- Misses        594      597       +3     
Flag Coverage Δ
unittests 84.28% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/defcomp.jl 79.03% <100.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c683a5...943fd46. Read the comment docs.

@lrennels lrennels merged commit 288c1e2 into master Nov 17, 2021
@lrennels lrennels deleted the default-symbol branch November 17, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant