Tasks: Fix Hop bridger validations #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalende
force-pushed
the
tasks/fix_hop_bridger_validations
branch
from
e7ca0a4 to
880bcb7
Compare
lgalende
commented
Oct 15, 2023
lgalende
commented
Oct 15, 2023
Comment on lines
310
to
311
| const amountAfterFees = amount.sub(fee) | ||
| const minAmountOut = amountAfterFees.mul(fp(1).sub(slippage)).div(fp(1)) |
There was a problem hiding this comment.
Where is the max fee being set?
There was a problem hiding this comment.
Nowhere. The config is being ignored
We discussed offline that it should raise an error when the max fee is not set and the fee is not 0
facuspagnuolo
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes related to Hop bridger validations:
feeis considered inside themin amount outmax fee pctis now an absolute value instead of a percentage. And thismax feeconfig is now implemented in theBase Bridge Task