Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 3.5.0 #176

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Prepare for 3.5.0 #176

merged 3 commits into from
Aug 7, 2023

Conversation

halostatue
Copy link
Member

@halostatue halostatue commented Aug 7, 2023

  • 1 minor enhancement:

    • Robb Shecter changed the default log level for duplicate type variant from
      warn to debug in #170. This works because MIME::Types.logger is
      intended to fit the ::Logger interface, and the default logger
      (WarnLogger) is a subclass of ::Logger that passes through to
      Kernel.warn.

      • Further consideration has changed cache load messages from warn to
        error and deprecation messages from warn to debug.
  • 1 bug fix:

    • Added a definition of MIME::Type#hash. Contributed by Alex Vondrak in
      #167, fixing #166.
  • Dependency and CI updates:

    • Update the .github/workflows/ci.yml workflow to test Ruby 3.2 and more
      reliably test certain combinations rather than depending on exclusions.

    • Change .standard.yml configuration to format for Ruby 2.3 as certain files
      are not properly detected with Ruby 2.0.

      • Change from hoe-git to hoe-git2 to support Hoe version 4.

      • Apply standardrb --fix.

      • The above changes have resulted in the Soft deprecation of Ruby versions
        below 2.6. Any errors reported for Ruby versions 2.0, 2.1, 2.2, 2.3, 2.4,
        and 2.5 will be resolved, but maintaining CI for these versions is
        unsustainable.


This change is Reviewable

@halostatue halostatue self-assigned this Aug 7, 2023
halostatue and others added 3 commits August 7, 2023 00:01
- 1 bug fix:

  - Added a definition of `MIME::Type#hash`. Contributed by Alex Vondrak
    in [#167][], fixing [#166][].

- Dependency and CI updates:

  - Update the .github/workflows/ci.yml workflow to test Ruby 3.2 and
    more reliably test certain combinations rather than depending on
    exclusions.

  - Change `.standard.yml` configuration to format for Ruby 2.3 as
    certain files are not properly detected with Ruby 2.0.

    - Change from `hoe-git` to `hoe-git2` to support Hoe version 4.

    - Apply `standardrb --fix`.

    - The above changes have resulted in the soft deprecation of Ruby
      versions below 2.6. Any errors reported for Ruby versions 2.0,
      2.1, 2.2, 2.3, 2.4, and 2.5 will be resolved, but maintaining CI
      for these versions is unsustainable.

[#166]: #166
[#167]: #167
...for the 'already registered' warning.

Closes #170.
- Also update other message log levels.
@halostatue halostatue changed the title Prepare for 3.4.2 Prepare for 3.5.0 Aug 7, 2023
@halostatue halostatue merged commit 327016e into main Aug 7, 2023
29 of 30 checks passed
@halostatue halostatue deleted the v3-cleanup branch August 7, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants