Added 'vtt' file extension to WebVTT mime type (text/vtt). #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine; can you modify this so that you’re only modifying the |
|
Cool, thanks for considering. I fixed it. |
|
(Another force-push as I was confusing the commit messages.) |
|
Thanks for the contribution! |
halostatue
added a commit
that referenced
this pull request
Sep 2, 2021
- Updated the Apache and IANA media registry entries as of release date. - Added file extension for WebVTT text format. [#46].
|
I’ve released a new version with this in it. |
|
Thanks for the quick action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon
MIME::Types.type_for(...)(usingruby-mime-types) not giving any results for.vttfiles (WebVTT, mime type 'text/vtt', https://www.w3.org/TR/webvtt1/).Further observation showed that the mime type
text/vttwas actually added in Update 3.2020.0425 (8ee4e6b), but it did not reference any file extensions.This change is