Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry for application/x-ms-dos-executable #28

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

YoranBrondsema
Copy link
Contributor

No description provided.

@halostatue
Copy link
Member

Hi. This change itself is fine, but note that the exe extension is also associated with application/octet-stream, application/x-msdos-program, and application/x-msdownload. I don’t think it should be removed from x-ms-dos-program or x-msdownload, but we may want to remove it from application/octet-stream.

@YoranBrondsema
Copy link
Contributor Author

@halostatue Thanks for the quick reply. I removed the exe extension from application/octet-stream.

Also, I wasn't sure what to put as encoding for application/x-ms-dos-executable. From what I see, most encodings in application.yaml are set to base64. But I'm not sure that a Windows executable is encoded in base64? Rather than putting something wrong, I left it empty, assuming that mime-types-data can cope with MIME types without an encoding specified.

@halostatue
Copy link
Member

The default encoding for application/* is base64 IIRC, but I’d have to check. I’ll merge this and release it over the holidays, so you should see it for January.

@YoranBrondsema
Copy link
Contributor Author

Great, thanks! Happy holidays.

@halostatue halostatue merged commit 701062e into mime-types:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants