Block migration db flag (only migrate once) #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBurkett
approved these changes
Dec 8, 2020
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 11, 2024
…imble#3512) * rework migrate_db_v2_v3 * db flag to track block migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3511
We only need to run the block migration process to completion once, to migrate existing blocks from v2 -> v3.
This PR introduces -
batch.is_blocks_v3_migrated()batch.set_blocks_v3_migrated(true)BoolFlag(de/ser of simple bool value in lmdb)BOOL_FLAG_PREFIXprefix for arbitrary bool flags in the dbBLOCKS_V3_MIGRATEDlmdb key for this specific bool flagBoolFlagand the associated db code should be reusable if we decide to store additional flags in the db.This PR also reworks the actual migration process to reduce the amount of deserialization attempts required to determine which blocks do need migrating. This will reduce the time required for the initial migration process.
We were attempting reads of both
v2andv3format and looking for errors duringv3.We now do a single
v3read and only on failure do we perform the additionalv2read.Empty blocks do not need to be migrated (no inputs to migrate) which is why we can skip successful
v3reads.And for these we do not need the additional redundant
v2read.After a successful migration, subsequent node restarts will result in -