refactor get_ser() to use get_with() internally #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
less code duplication and a cleaner code path batch.exists() now aware of current write tx
|
Going to merge this. It's a refactor, no change to behavior. Tested locally and against mainnet. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors some of the lmdb batch internals.
get_with()deserialization function now fallibleget_ser()usesget_with()internally and passes in default deserialization strategyget_ser_access()batch.exists()now aware of current write tx and not simply a wrapper todb.exists()Related #3450 (which prompted this refactor).
We use
get_ser()heavily as this uses the default deserialization strategy. But we also occasionally want more flexible access (see #3450). This PR consolidatesget_with()andget_ser().