Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard fork tryout: better PoW encapsulation in block header #1478

Merged
merged 6 commits into from
Sep 10, 2018
Merged

Hard fork tryout: better PoW encapsulation in block header #1478

merged 6 commits into from
Sep 10, 2018

Conversation

ignopeverell
Copy link
Contributor

Introducing a struct to encapsulate all PoW fields. This has the effect to reorder block header fields.

@tromp
Copy link
Contributor

tromp commented Sep 5, 2018

Will it also add the scaling factor for secondary PoW?

@ignopeverell
Copy link
Contributor Author

Just add it and keep it unused for now? Wasn't planning on adding seconday PoW validation, factor adjustment, etc

@tromp
Copy link
Contributor

tromp commented Sep 5, 2018

Yep; just add "for future use". Makes hard-fork slightly more interesting due to change in header size.

@ignopeverell
Copy link
Contributor Author

Alright then, I'll add that up.

@ignopeverell
Copy link
Contributor Author

Ready for review from whoever wants to.

@ignopeverell ignopeverell merged commit ecf2060 into mimblewimble:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants